Are there any extra onboarding costs when if we choose to upgrade our themed website after 3 years?

If you choose a new site after 3 years there are no additional costs, unless you wish to make changes to the functionality or content, that is provided out of the box.